Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): fixed deb tester sub image. #2100

Merged
merged 1 commit into from
Jun 29, 2022
Merged

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Jun 29, 2022

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP
Copy link
Contributor Author

FedeDP commented Jun 29, 2022

/cc @leogr @jasondellaluce

This won't pass integration tests because they're currently broken :/

EDIT: of course, i broke the image...

@poiana poiana requested a review from jasondellaluce June 29, 2022 08:09
@FedeDP FedeDP mentioned this pull request Jun 29, 2022
15 tasks
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/milestone 0.32.1

@poiana poiana added this to the 0.32.1 milestone Jun 29, 2022
@poiana poiana added the lgtm label Jun 29, 2022
@poiana
Copy link
Contributor

poiana commented Jun 29, 2022

LGTM label has been added.

Git tree hash: 1756fd6e0522aed5b1a51e94248475010e9106f9

Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana merged commit 610b678 into master Jun 29, 2022
@poiana poiana deleted the fix/deb_tester_image branch June 29, 2022 09:52
@poiana
Copy link
Contributor

poiana commented Jun 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants