refactor(userspace/falco)!: make output rate limiter optional and output engine explicitly thread-safe #2139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 21, 2022
|
/milestone 0.33.0 |
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
…work Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
jasondellaluce
force-pushed
the
refactor/token-bucket-thread-safe
branch
from
decb74d to
65655c5
Compare
jasondellaluce
changed the title
|
/milestone 0.33.0 |
|
LGTM label has been added. Git tree hash: 341e5162d6db27c76885884773d44ff10a2ab958
|
FedeDP
approved these changes
Aug 23, 2022
| # rate of falco notifications. This throttling is controlled by the following configuration | ||
| # options: | ||
| # rate of Falco notifications. One rate limiter is assigned to each event | ||
| # source, so that alerts coming from one can't influence the throttling |
There was a problem hiding this comment.
We are already talking about multiple event sources; isn't it premature here? :D
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, jasondellaluce, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
This is an alternative to #2080, that makes the token-bucket alert rate limiter optional by default. When enabled, the output framework now uses one token bucket for each inspector. Once we have multi-source support, alerts coming from one source won't influence the rate limiting of the others. At the same time, this will also be thread-safe because each thread will be own its own token bucket.
Which issue(s) this PR fixes:
Fixes #1333
Special notes for your reviewer:
Does this PR introduce a user-facing change?: