Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enrich pull request template #2162

Merged
merged 3 commits into from
Aug 11, 2022

Conversation

Andreagit97
Copy link
Member

What type of PR is this?

/kind design

/kind documentation

Any specific area of the project related to this PR?

What this PR does / why we need it:

This PR tries to enrich the pull request template with some new labels

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Andrea Terzolo <andrea.terzolo@polito.it>
Signed-off-by: Andrea Terzolo <andrea.terzolo@polito.it>
jasondellaluce
jasondellaluce previously approved these changes Aug 10, 2022
Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thanks, this was kind of outdated!

@poiana
Copy link
Contributor

poiana commented Aug 10, 2022

LGTM label has been added.

Git tree hash: 0bd3fc0b653832d970d7942a3b46cf2aa8ab80ca

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment, otherwise SGTM 👍

.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
@leogr
Copy link
Member

leogr commented Aug 10, 2022

/milestone 0.33.0

@poiana poiana added this to the 0.33.0 milestone Aug 10, 2022
Signed-off-by: Andrea Terzolo <andrea.terzolo@polito.it>
Co-authored-by: Leonardo Grasso <me@leonardograsso.com>
Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Aug 11, 2022
@poiana
Copy link
Contributor

poiana commented Aug 11, 2022

LGTM label has been added.

Git tree hash: de87d5eccc766c246268bbed69cc57e5809d451a

@poiana
Copy link
Contributor

poiana commented Aug 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 6971ed2 into falcosecurity:master Aug 11, 2022
@Andreagit97 Andreagit97 deleted the enrich_pull_request_template branch October 15, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants