Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vote: update(OWNERS): add Andrea Terzolo to owners #2185

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

Andreagit97
Copy link
Member

@Andreagit97 Andreagit97 commented Aug 31, 2022

What type of PR is this?

/kind documentation

Any specific area of the project related to this PR?

None

What this PR does / why we need it:

Hi folks 🖖 As said in today's community call, I propose myself as a maintainer for Falco core repo.
I have been highly involved in various activities linked to Falco and its surrounding projects and I tried my best to help review code and help people all around the community, I'm looking forward to helping also here :)
Please if you have any suggestions or concerns feel free to share!
Thank you!

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Andrea Terzolo <andrea.terzolo@polito.it>
@leogr
Copy link
Member

leogr commented Sep 1, 2022

Per our governance, this requires a majority vote. So, @falcosecurity/falco-maintainers cast your vote, please 😃

Hold until we get the majority.
/hold

@leogr
Copy link
Member

leogr commented Sep 1, 2022

Ofc, big +1 from me 😄

@leogr leogr changed the title update(OWNERS): add Andrea Terzolo to owners vote: update(OWNERS): add Andrea Terzolo to owners Sep 1, 2022
@jasondellaluce
Copy link
Contributor

+1

@FedeDP
Copy link
Contributor

FedeDP commented Sep 1, 2022

+1!!

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The majority has been reached 🥳

/unhold

@poiana
Copy link
Contributor

poiana commented Sep 2, 2022

LGTM label has been added.

Git tree hash: af2fe6e7ac72d05c438b875d5522d9ef215f8700

@poiana poiana added the approved label Sep 2, 2022
@leogr
Copy link
Member

leogr commented Sep 2, 2022

/milestone 0.33.0

@poiana poiana added this to the 0.33.0 milestone Sep 2, 2022
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana merged commit 934ae2f into falcosecurity:master Sep 2, 2022
@poiana
Copy link
Contributor

poiana commented Sep 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, jasondellaluce, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [FedeDP,jasondellaluce,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Andreagit97 Andreagit97 deleted the update_maintainers branch October 15, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants