Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(userspace/falco): create grpc unix socket and gvisor endpoint path automatically #2189

Merged
merged 2 commits into from
Sep 9, 2022

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Sep 2, 2022

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area engine

What this PR does / why we need it:

It is also able to handle multipart paths, like /run/falco/falco/falco/falco.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

new(userspace/falco): automatically create paths for grpc unix socket and gvisor endpoint.

…h automatically.

It is also able to handle multipart paths, like /run/falco/falco/falco/falco.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP
Copy link
Contributor Author

FedeDP commented Sep 2, 2022

/milestone 0.33.0

@poiana poiana added this to the 0.33.0 milestone Sep 2, 2022
…that '/' is the path delim.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Sep 6, 2022

LGTM label has been added.

Git tree hash: fdbe5bf5a6b86f7ea9cef58524c9ebe87ab40fef

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@poiana
Copy link
Contributor

poiana commented Sep 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, jasondellaluce, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [FedeDP,jasondellaluce,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants