update(falco): add container-gvisor and kubernetes-gvisor print options #2288
Conversation
Signed-off-by: Luca Guerra <luca@guerra.sh>
|
/milestone 0.34 |
|
@jasondellaluce: The provided milestone is not valid for this repository. Milestones in this repository: [ Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/milestone 0.34.0 |
|
LGTM label has been added. Git tree hash: 35c5c0a8aabe8a32a9c66350ae547a2418d7b3d3
|
| else if(m_options.print_additional == "k" || m_options.print_additional == "kubernetes") | ||
| { | ||
| output_format = "k8s.ns=%k8s.ns.name k8s.pod=%k8s.pod.name container=%container.id"; | ||
| replace_container_info = true; | ||
| } | ||
| else if(m_options.print_additional == "kg" ||m_options.print_additional == "kubernetes-gvisor") |
There was a problem hiding this comment.
| else if(m_options.print_additional == "kg" ||m_options.print_additional == "kubernetes-gvisor") | |
| else if(m_options.print_additional == "kg" || m_options.print_additional == "kubernetes-gvisor") |
LucaGuerra
force-pushed
the
update/add-container-gvisor-kubernetes-gvisor
branch
from
cfe7880 to
30a3024
Compare
Signed-off-by: Luca Guerra <luca@guerra.sh>
LucaGuerra
force-pushed
the
update/add-container-gvisor-kubernetes-gvisor
branch
from
30a3024 to
5949cd9
Compare
|
LGTM label has been added. Git tree hash: 8e1a1986b2d157f150b22a6ee2a46bd633f72a1d
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, leogr, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Luca Guerra luca@guerra.sh
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
When running with gVisor on a host with containers, you probably want to print details with
container-gvisor, when using kuberneteskubernetes-gvisor, as they're equivalent tocontainerandkubernetesbut add information useful for gVisor (currently vtid and vpid, but could be more). These can easily be used by the helm chart as well.Also, remove the previous
ifthat was trying to set this automatically. It is cleaner to specifiy the print format explicitly like we currently do with k8s.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: