Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support older rhel distros in falco-driver-loader #2312

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

gentooise
Copy link
Contributor

@gentooise gentooise commented Dec 6, 2022

With current version, this error comes out while trying to run falco-driver-loader on RHEL 6:

Getting environment information
Detected an unsupported target system, please get in touch with the Falco community

because /etc/os-release file is not there.

Instead, /etc/redhat-release file is present (just like /etc/centos-release in older CentOS distros, already supported).

Tested on:

Linux rhel6.localdomain 2.6.32-754.el6.x86_64 #1 SMP Thu May 24 18:18:25 EDT 2018 x86_64 x86_64 x86_64 GNU/Linux

Signed-off-by: gentooise andrea.genuise@ibm.com

What type of PR is this? not sure

Any specific area of the project related to this PR? not sure

Special notes for your reviewer: none

Does this PR introduce a user-facing change?:

new(scripts): Support older RHEL distros in falco-driver-loader script

Tested on RHEL 6

Signed-off-by: gentooise <andrea.genuise@ibm.com>
@poiana
Copy link
Contributor

poiana commented Dec 6, 2022

Welcome @gentooise! It looks like this is your first PR to falcosecurity/falco 🎉

@poiana poiana added the size/XS label Dec 6, 2022
@poiana poiana requested review from Kaizhe and mstemm December 6, 2022 16:28
@FedeDP
Copy link
Contributor

FedeDP commented Dec 6, 2022

Thank you very much!
/milestone 0.34.0

@poiana poiana added this to the 0.34.0 milestone Dec 6, 2022
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Dec 6, 2022

LGTM label has been added.

Git tree hash: 561dca8a54c4eae1deb0cb867739ba26cf06a062

@poiana poiana added the approved label Dec 6, 2022
Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

/approve

@poiana
Copy link
Contributor

poiana commented Dec 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, gentooise, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [FedeDP,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 70dfdb2 into falcosecurity:master Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants