update(ci): update ci jobs to generate Falco images with the modern BPF probe #2320

Andreagit97 · 2022-12-13T14:58:58Z

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area build

/area CI

What this PR does / why we need it:

This PR brings the necessary changes in the circle-ci jobs to build a Falco image for the modern bpf probe. I added a docker image that returns Falco packages as output (deb, rpm, tar).

This PR is the dual of #2282, the idea is to merge this for the release and leave the other PR open until Falco 0.34 is released so users can continue to test the modern probe if they want :)

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

update(ci): update ci jobs to generate Falco images with the modern BPF probe

FedeDP · 2022-12-13T15:06:26Z

Can you use some comments in the circleci config? :)

Andreagit97

Added some comments on arm64 job, they are all valid for the centos7 one

Andreagit97 · 2022-12-13T15:45:14Z

.circleci/config.yml

+            sudo update-alternatives --install /usr/bin/clang clang /usr/bin/clang-14 90
+            sudo update-alternatives --install /usr/bin/llvm-strip llvm-strip /usr/bin/llvm-strip-14 90


here we set llvm-14 and clang-14 as default in the system

Andreagit97 · 2022-12-13T15:45:29Z

.circleci/config.yml

+            git clone https://github.com/libbpf/bpftool.git --branch v7.0.0 --single-branch
+            cd bpftool
+            git submodule update --init
+            cd src && sudo make install


here we install bpftool

Andreagit97 · 2022-12-13T15:46:32Z

.circleci/config.yml

-            docker run -e BUILD_TYPE="release" -it -v /tmp/source-arm64:/source -v /tmp/build-arm64:/build \
-              falcosecurity/falco-builder:latest \
-              package
+            mkdir -p /tmp/source-arm64/falco/skeleton-build


here we build in a separate build dir called skeleton-build the modern bpf skeleton

Andreagit97 · 2022-12-13T15:50:57Z

.circleci/config.yml

-            cp /tmp/build-arm64/release/*.deb /tmp/packages
-            cp /tmp/build-arm64/release/*.tar.gz /tmp/packages
-            cp /tmp/build-arm64/release/*.rpm /tmp/packages
+            DOCKER_BUILDKIT=1 docker build -f /tmp/source-arm64/falco/docker/builder/modern-falco-builder.Dockerfile --output type=local,dest=/tmp --build-arg CMAKE_OPTIONS="-DCMAKE_BUILD_TYPE=Release -DUSE_BUNDLED_DEPS=On -DFALCO_ETC_DIR=/etc/falco -DBUILD_FALCO_MODERN_BPF=ON -DMODERN_BPF_SKEL_DIR=/source/skeleton-build/skel_dir -DBUILD_DRIVER=Off -DBUILD_BPF=Off" --build-arg DEST_BUILD_DIR=/build-arm64/release /tmp/source-arm64/falco


DOCKER_BUILDKIT is needed to use the --output docker command

as a build arg we pass CMAKE_OPTIONS=, so all the CMake options necessary to build Falco with the modern probe, we need to provide the external built skeleton with the MODERN_BPF_SKEL_DIR CMake variable, note that the provided path is already relative to the container file system not to the host one.

--build-arg DEST_BUILD_DIR=/build-arm64/release here we are saying the container to copy the build directory in this location of the ubuntu 22.04 machine, in this way we can reuse this build directory in the test-integrations jobs

/tmp/source-arm64/falco this is the docker build context with the source code of Falco

FedeDP · 2022-12-15T11:31:23Z

/hold

Signed-off-by: Andrea Terzolo <andrea.terzolo@polito.it>

Andreagit97 · 2022-12-15T16:14:43Z

test/CMakeLists.txt

@@ -1,4 +1,6 @@
 add_subdirectory(trace_files)

-add_subdirectory(plugins)
-add_subdirectory(confs/plugins)
+if(NOT MUSL_OPTIMIZED_BUILD)


in musl build we don't have plugins so I've disabled the testing phase for plugins

Signed-off-by: Andrea Terzolo <andrea.terzolo@polito.it>

Andreagit97 · 2022-12-16T11:22:14Z

I've bumped the resource classes to large in build-centos7 and build-arm64 jobs since we noticed some timeout issues in these 2 jobs.

FedeDP · 2022-12-16T11:30:18Z

This PR also bumps libs and driver to latest tags: 0.10.0 and 4.0.0+driver! Thanks Andrea!

FedeDP

/approve

poiana · 2022-12-16T11:43:47Z

LGTM label has been added.

Git tree hash: 9eecdbdc0bf2cb2823d64ed0fcd7cfa706378004

Signed-off-by: Andrea Terzolo <andrea.terzolo@polito.it>

FedeDP

/approve

poiana · 2022-12-16T15:02:16Z

LGTM label has been added.

Git tree hash: 2eeec656e89a1bab5fa9ca172223ad917bddd69c

jasondellaluce

/approve

poiana · 2022-12-21T10:24:46Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [Andreagit97,FedeDP,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Andreagit97 · 2022-12-21T10:25:48Z

/unhold

Andreagit97 mentioned this pull request Dec 13, 2022

[WIP] update(CI): Integration of modern BPF probe into Falco #2282

Closed

Andreagit97 added this to the 0.34.0 milestone Dec 13, 2022

Andreagit97 commented Dec 13, 2022

View reviewed changes

poiana added dco-signoff: yes approved size/L labels Dec 13, 2022

Andreagit97 force-pushed the new/modern_bpf branch 3 times, most recently from 461c1df to dc818cf Compare December 15, 2022 10:41

poiana added the do-not-merge/hold label Dec 15, 2022

Andreagit97 added 2 commits December 15, 2022 14:25

chore: bump libs/driver version

2b3b543

Signed-off-by: Andrea Terzolo <andrea.terzolo@polito.it>

update(ci): update ci jobs to generate Falco images with modern probe

ae51c03

Signed-off-by: Andrea Terzolo <andrea.terzolo@polito.it>

Andreagit97 force-pushed the new/modern_bpf branch 3 times, most recently from 0644a96 to 6338a72 Compare December 15, 2022 15:15

Andreagit97 commented Dec 15, 2022

View reviewed changes

update(ci): support modern bpf with musl build

cf39d87

Signed-off-by: Andrea Terzolo <andrea.terzolo@polito.it>

Andreagit97 force-pushed the new/modern_bpf branch from 6338a72 to cf39d87 Compare December 16, 2022 11:03

ci: bump resource class

bb33841

Signed-off-by: Andrea Terzolo <andrea.terzolo@polito.it>

FedeDP previously approved these changes Dec 16, 2022

View reviewed changes

poiana assigned FedeDP Dec 16, 2022

poiana added the lgtm label Dec 16, 2022

update(ci): bump also musl job

f5a7597

Signed-off-by: Andrea Terzolo <andrea.terzolo@polito.it>

Andreagit97 dismissed FedeDP’s stale review via f5a7597 December 16, 2022 12:25

poiana removed the lgtm label Dec 16, 2022

poiana requested a review from FedeDP December 16, 2022 12:25

FedeDP approved these changes Dec 16, 2022

View reviewed changes

poiana added the lgtm label Dec 16, 2022

jasondellaluce approved these changes Dec 21, 2022

View reviewed changes

poiana assigned jasondellaluce Dec 21, 2022

poiana removed the do-not-merge/hold label Dec 21, 2022

poiana merged commit decabbc into master Dec 21, 2022

poiana deleted the new/modern_bpf branch December 21, 2022 10:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update(ci): update ci jobs to generate Falco images with the modern BPF probe #2320

update(ci): update ci jobs to generate Falco images with the modern BPF probe #2320

Andreagit97 commented Dec 13, 2022

FedeDP commented Dec 13, 2022

Andreagit97 left a comment

Andreagit97 Dec 13, 2022

Andreagit97 Dec 13, 2022

Andreagit97 Dec 13, 2022

Andreagit97 Dec 13, 2022 •

edited

Loading

FedeDP commented Dec 15, 2022

Andreagit97 Dec 15, 2022

Andreagit97 commented Dec 16, 2022

FedeDP commented Dec 16, 2022

FedeDP left a comment

poiana commented Dec 16, 2022

FedeDP left a comment

poiana commented Dec 16, 2022

jasondellaluce left a comment

poiana commented Dec 21, 2022

Andreagit97 commented Dec 21, 2022

		sudo update-alternatives --install /usr/bin/clang clang /usr/bin/clang-14 90
		sudo update-alternatives --install /usr/bin/llvm-strip llvm-strip /usr/bin/llvm-strip-14 90

update(ci): update ci jobs to generate Falco images with the modern BPF probe #2320

update(ci): update ci jobs to generate Falco images with the modern BPF probe #2320

Conversation

Andreagit97 commented Dec 13, 2022

FedeDP commented Dec 13, 2022

Andreagit97 left a comment

Choose a reason for hiding this comment

Andreagit97 Dec 13, 2022

Choose a reason for hiding this comment

Andreagit97 Dec 13, 2022

Choose a reason for hiding this comment

Andreagit97 Dec 13, 2022

Choose a reason for hiding this comment

Andreagit97 Dec 13, 2022 • edited Loading

Choose a reason for hiding this comment

FedeDP commented Dec 15, 2022

Andreagit97 Dec 15, 2022

Choose a reason for hiding this comment

Andreagit97 commented Dec 16, 2022

FedeDP commented Dec 16, 2022

FedeDP left a comment

Choose a reason for hiding this comment

poiana commented Dec 16, 2022

FedeDP left a comment

Choose a reason for hiding this comment

poiana commented Dec 16, 2022

jasondellaluce left a comment

Choose a reason for hiding this comment

poiana commented Dec 21, 2022

Andreagit97 commented Dec 21, 2022

Andreagit97 Dec 13, 2022 •

edited

Loading