Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add deprecation warning for Mesos #2328

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Conversation

leogr
Copy link
Member

@leogr leogr commented Dec 16, 2022

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

/area CI

What this PR does / why we need it:

Since we have not received convincing feedback to directly remove Mesos but there are no compelling reasons to keep this feature, I'm proposing a more prudent approach: add a deprecation warning for this release, and then completely remove it in the next release.

Motivation and details are reported in #2160 I'm going to close in favor of this.

/milestone 0.34.0

Does this PR introduce a user-facing change?:

update: Mesos support is now deprecated and will be removed in the next version.

…e flags

Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@leogr
Copy link
Member Author

leogr commented Dec 16, 2022

/hold

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Dec 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,FedeDP,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leogr
Copy link
Member Author

leogr commented Jan 9, 2023

/hold cancel

@poiana poiana merged commit 280fcfe into master Jan 9, 2023
@poiana poiana deleted the update/deprecate-mesos-support branch January 9, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants