Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(CI): upgrade toolchain in modern falco builder dockerfile #2337

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

Andreagit97
Copy link
Member

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area CI

What this PR does / why we need it:

Update the toolchain in the centos7 dockerfile used to build the modern probe

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Andrea Terzolo <andrea.terzolo@polito.it>
@poiana poiana requested review from Kaizhe and leogr December 22, 2022 16:15
@Andreagit97 Andreagit97 changed the title update: modern falco builder dockerfile [WIP]: update: modern falco builder dockerfile Dec 22, 2022
@Andreagit97 Andreagit97 changed the title [WIP]: update: modern falco builder dockerfile [WIP]: update: update toolchain in modern falco builder dockerfile Dec 22, 2022
@Andreagit97 Andreagit97 changed the title [WIP]: update: update toolchain in modern falco builder dockerfile update(CI): upgrade toolchain in modern falco builder dockerfile Dec 22, 2022
Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Dec 23, 2022

LGTM label has been added.

Git tree hash: 6fbc8d118831c6520021a8d4fe61a445fd7dbd01

@jasondellaluce
Copy link
Contributor

/milestone 0.34.0

@poiana poiana added this to the 0.34.0 milestone Dec 23, 2022
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana merged commit 19d5430 into master Jan 9, 2023
@poiana poiana deleted the Andreagit97-patch-1 branch January 9, 2023 08:04
@poiana
Copy link
Contributor

poiana commented Jan 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants