-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new(userspace/falco): add webserver endpoint for retrieving internal version numbers #2356
Conversation
…ion numbers Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
…support Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
…versions Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
/milestone 0.34.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, a couple of minor comments.
I think we should explicitly state in the config that webserver will be used by falcoctl for its feed feature.
I think falcoctl could also be manually configured though.
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 12f3cb1c21f376b7a96257f1ed220f96b13ba792
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, jasondellaluce, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
This PR adds a new webserver endopoint
/versions
that can be used to retrieve the versions of the internal Falco components. This can be specifically useful to get this information from a running instance of Falco from external tools, either locally or when deployed in Kubernetes.Since this happens at runtime, the JSON response also includes the version of the loaded plugins.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
The JSON output is coherent to the output of
falco --version -o json_output=true
and withfalco --support
.Does this PR introduce a user-facing change?: