-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update(CI): mitigate frequent failure in CircleCI jobs #2375
Conversation
b0e15c6
to
1f8b63d
Compare
Signed-off-by: Andrea Terzolo <andrea.terzolo@polito.it>
1f8b63d
to
75eb74b
Compare
Signed-off-by: Andrea Terzolo <andrea.terzolo@polito.it>
75eb74b
to
d06f977
Compare
I love this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 902a3da8583eec555e74fa3e61d0e71a3f02b8fb
|
COPY --from=build-stage /build/release/cloudtrail-plugin-prefix ${DEST_BUILD_DIR}/cloudtrail-plugin-prefix | ||
COPY --from=build-stage /build/release/cloudtrail-rules-prefix ${DEST_BUILD_DIR}/cloudtrail-rules-prefix | ||
COPY --from=build-stage /build/release/falcosecurity-rules-application-prefix ${DEST_BUILD_DIR}/falcosecurity-rules-application-prefix | ||
COPY --from=build-stage /build/release/falcosecurity-rules-falco-prefix ${DEST_BUILD_DIR}/falcosecurity-rules-falco-prefix | ||
COPY --from=build-stage /build/release/falcosecurity-rules-local-prefix ${DEST_BUILD_DIR}/falcosecurity-rules-local-prefix | ||
COPY --from=build-stage /build/release/json-plugin-prefix ${DEST_BUILD_DIR}/json-plugin-prefix | ||
COPY --from=build-stage /build/release/k8saudit-plugin-prefix ${DEST_BUILD_DIR}/k8saudit-plugin-prefix | ||
COPY --from=build-stage /build/release/k8saudit-rules-prefix ${DEST_BUILD_DIR}/k8saudit-rules-prefix | ||
COPY --from=build-stage /build/release/scripts ${DEST_BUILD_DIR}/scripts | ||
COPY --from=build-stage /build/release/test ${DEST_BUILD_DIR}/test | ||
COPY --from=build-stage /build/release/userspace/falco/falco ${DEST_BUILD_DIR}/userspace/falco/falco | ||
COPY --from=build-stage /build/release/userspace/falco/config_falco.h ${DEST_BUILD_DIR}/userspace/falco/config_falco.h | ||
COPY --from=build-stage /build/release/falco-*.tar.gz ${DEST_BUILD_DIR}/ | ||
COPY --from=build-stage /build/release/falco-*.deb ${DEST_BUILD_DIR}/ | ||
COPY --from=build-stage /build/release/falco-*.rpm ${DEST_BUILD_DIR}/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit concerned about keeping these in sync with the build process, however, it's acceptable at the moment 👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
This PR performs 2 main actions on the modern-falco-builder to mitigate some issues with the Falco CI:
make
commands into different docker RUN instructions, in this way we can catch errors in single steps. With the previous approach 👇 we were not able to catch failures whenmake package
failed: the CI job was successful but the build failed https://app.circleci.com/pipelines/github/falcosecurity/falco/3647/workflows/1fca77ee-28c8-4a4c-8344-ff44f3db447f/jobs/31261context timeout exceeding
this is because the modern builder container is not able to copy the whole Falco build directory from the container to the CircleCI job's VM. The size of the build directory is almost6 GB
, this huge size causes this context timeout! With this patch, we export only what is really relevant to our integration tests reducing the build directory dimension from6 GB
to600 MB
!This is not the final solution obviously this is just a workaround to mitigate there frequent CI failures we are facing
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: