Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scripts): fix falco-driver-loader for some debian kernels. #2377

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Jan 25, 2023

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

What this PR does / why we need it:

See #2374, falcosecurity/test-infra#1097, falcosecurity/kernel-crawler#114

Which issue(s) this PR fixes:

Fixes #2374

Special notes for your reviewer:

To help test this for Falco 0.34.1, i pushed a patched falco-driver-loader image: fededp/falco-driver-loader:0.34.1_fixed.

Does this PR introduce a user-facing change?:

fix(scripts): properly support debian kernel releases embedded in kernel version

@FedeDP
Copy link
Contributor Author

FedeDP commented Jan 25, 2023

/milestone 0.35.0

@poiana poiana added this to the 0.35.0 milestone Jan 25, 2023
@FedeDP FedeDP force-pushed the fix/debian_kernelrelease branch from c67884d to e32e918 Compare January 25, 2023 15:03
@FedeDP FedeDP force-pushed the fix/debian_kernelrelease branch 2 times, most recently from 62649c1 to 137fc00 Compare January 26, 2023 15:03
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP FedeDP force-pushed the fix/debian_kernelrelease branch from 137fc00 to 101aa20 Compare April 13, 2023 11:43
@FedeDP
Copy link
Contributor Author

FedeDP commented Apr 13, 2023

I pushed a fededp/falco-driver-loader:0.34.1_fixed image to be tested by users affected. It contains exactly the same falcosecurity/falco-driver-loader:0.34.1 image but with the debian fixes applied on top.

@rao-hassan-1
Copy link

This fixed my issue. I tested this image out fededp/falco-driver-loader:0.34.1_fixed and got the following logs in the falco driver-loader:

* Setting up /usr/src links from host
* Running falco-driver-loader for: falco version=0.34.1, driver version=4.0.0+driver, arch=x86_64, kernel release=5.10.0-0.deb10.17-amd64, kernel version=1
* Running falco-driver-loader with: driver=module, compile=yes, download=yes

================ Cleaning phase ================

* 1. Check if kernel module 'falco' is still loaded:
- OK! There is no 'falco' module loaded.

* 2. Check all versions of kernel module 'falco' in dkms:
- OK! There are no 'falco' module versions in dkms.

[SUCCESS] Cleaning phase correctly terminated.

================ Cleaning phase ================

* Looking for a falco module locally (kernel 5.10.136-1-amd64)
* Filename 'falco_debian_5.10.136-1-amd64_1.ko' is composed of:
 - driver name: falco
 - target identifier: debian
 - kernel release: 5.10.136-1-amd64
 - kernel version: 1
* Trying to download a prebuilt falco module from https://download.falco.org/driver/4.0.0%2Bdriver/x86_64/falco_debian_5.10.136-1-amd64_1.ko
* Download succeeded
* Success: falco module found and inserted
Stream closed EOF for default/falco-5bvs8 (falco-driver-loader)

Before, I was running into issues of 404 not found when this falco driver loader would run. I tried to push a fix for this but that is not really the fix for this issue.

@rao-hassan-1
Copy link

Here's the link to my PR: falcosecurity/test-infra#1097 from which I was trying to fix this.

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Apr 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,FedeDP,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Debian 11 kernel version issue
5 participants