Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: add allowed types to falcoctl artifact follow service #2406

Merged
merged 2 commits into from
Feb 6, 2023

Conversation

loresuso
Copy link
Member

@loresuso loresuso commented Feb 6, 2023

Signed-off-by: Lorenzo Susini susinilorenzo1@gmail.com

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area tests

/area proposals

/area CI

What this PR does / why we need it:

Ensure the falcoctl service can follow only rulesfiles.
Waiting falcoctl version bump so the we can bump the version also here.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

build: upgrade to `falcoctl` v0.4.0

Signed-off-by: Lorenzo Susini <susinilorenzo1@gmail.com>
@leogr
Copy link
Member

leogr commented Feb 6, 2023

/milestone 0.34.0

@poiana poiana added this to the 0.34.0 milestone Feb 6, 2023
Andreagit97
Andreagit97 previously approved these changes Feb 6, 2023
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Feb 6, 2023

LGTM label has been added.

Git tree hash: 1153e282340714732d999153febb805a67f5364c

@poiana poiana added the approved label Feb 6, 2023
@poiana poiana removed the lgtm label Feb 6, 2023
@poiana poiana requested a review from Andreagit97 February 6, 2023 18:11
@loresuso loresuso changed the title wip: update: add allowed types to falcoctl artifact follow service update: add allowed types to falcoctl artifact follow service Feb 6, 2023
Signed-off-by: Lorenzo Susini <susinilorenzo1@gmail.com>
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@poiana poiana added the lgtm label Feb 6, 2023
@poiana
Copy link
Contributor

poiana commented Feb 6, 2023

LGTM label has been added.

Git tree hash: d3a31f178ee3025a699a9fc2e3c999605c2f1917

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Feb 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, leogr, loresuso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 6f994ee into falcosecurity:master Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants