Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: driver drop failed #2456

Merged
merged 7 commits into from
Mar 28, 2023
Merged

new: driver drop failed #2456

merged 7 commits into from
Mar 28, 2023

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Mar 24, 2023

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area engine

What this PR does / why we need it:

This PR bumps libs to latest master (falcosecurity/libs@c8b0d6a).
Moreover, it introduces a new syscall_drop_failed config option to instrument drivers to drop failed syscalls exit events, exposing the new feature impl by falcosecurity/libs#834.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

new(cmake): bumped libs to c8b0d6a8fdc1bb3ea9067bc2fdc3ae5858cff48f
new(userspace): add a new `syscall_drop_failed` config option to drop failed syscalls exit events

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
FedeDP added 2 commits March 24, 2023 16:33
…ed syscalls exit events.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP FedeDP force-pushed the new/driver_drop_failed branch from 5222984 to 43f3d8b Compare March 24, 2023 15:33
@FedeDP
Copy link
Contributor Author

FedeDP commented Mar 24, 2023

/milestone 0.35.0

@poiana poiana added this to the 0.35.0 milestone Mar 24, 2023
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
Copy link
Contributor

@incertum incertum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just few suggestions to improve wording.

falco.yaml Outdated Show resolved Hide resolved
userspace/falco/app/actions/helpers_inspector.cpp Outdated Show resolved Hide resolved
FedeDP and others added 2 commits March 27, 2023 17:17
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>

Co-authored-by: Melissa Kilby <melissa.kilby.oss@gmail.com>
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>

Co-authored-by: Melissa Kilby <melissa.kilby.oss@gmail.com>
incertum
incertum previously approved these changes Mar 27, 2023
Copy link
Contributor

@incertum incertum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't officially approve, but this LGTM!

leogr
leogr previously approved these changes Mar 28, 2023
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>

Co-authored-by: Jason Dellaluca <jasondellaluce@gmail.com>
@FedeDP FedeDP dismissed stale reviews from leogr and incertum via 04e0095 March 28, 2023 13:30
Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Mar 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, jasondellaluce, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [FedeDP,jasondellaluce,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 0b7ca28 into master Mar 28, 2023
@poiana poiana deleted the new/driver_drop_failed branch March 28, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants