cleanup(unit_tests): try making test_configure_interesting_sets more robust #2464
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind cleanup
/kind failing-test
Any specific area of the project related to this PR?
/area tests
What this PR does / why we need it:
@jasondellaluce still getting errors locally with current master, e.g.
Have been reading more about it and everywhere people warn that gtests can influence each other. SetUp and TearDown didn't do anything, oddly just changing some variable names per test did help 🤷♀️ ... now everything is passing again locally. Unsure if it's now also just random or really helped, at the same time these changes won't hurt at all. Let's see if the CI remains intact.
Also experimented with adding a generic syscall such as
init_module
to thes_sample_filters
... let's try adding it after the final libs patch to make sure we get consistent new / final behavior throughout.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: