Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(ci): properly set a concurrency for CI workflows. #2470

Merged
merged 2 commits into from
Apr 4, 2023

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Apr 4, 2023

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area CI

What this PR does / why we need it:

See falcosecurity/libs#1029 and falcosecurity/libs#1028

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP
Copy link
Contributor Author

FedeDP commented Apr 4, 2023

/milestone 0.35.0

@poiana poiana added the size/XS label Apr 4, 2023
@poiana poiana added this to the 0.35.0 milestone Apr 4, 2023
@FedeDP
Copy link
Contributor Author

FedeDP commented Apr 4, 2023

Note: conversely from the libs PR, i decided to stop all workflows triggered by the branch/pr on Falco (not just the CI one), because we have eg: codeQL that is pretty heavy too since it performs a full build.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>

Co-authored-by: Mauro Ezequiel Moltrasio <mmoltras@redhat.com>
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Apr 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,FedeDP,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 597f07c into master Apr 4, 2023
@poiana poiana deleted the cleanup/gha_concurrency branch April 4, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants