-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Falco branding guidelines #2493
Conversation
Signed-off-by: Aizhamal Nurmamat kyzy <aizhamal@sysdig.com>
Welcome @aijamalnk! It looks like this is your first PR to falcosecurity/falco 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @aijamalnk
Thank you for PR! I've left a suggestion (see below comment).
May you also open the PR on the website for the Falco branding page, please? I guess it would be better to merge both around the same time.
🙏
/milestone 0.35.0 |
Co-authored-by: Leonardo Grasso <me@leonardograsso.com> Signed-off-by: Aizhamal Nurmamat kyzy <aizhamal@google.com>
Signed-off-by: Aizhamal Nurmamat kyzy <aizhamal@sysdig.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Just waiting for https://falco.org/falco-brand to be published
Adding the proper link to the brand guides Co-authored-by: Leonardo Grasso <me@leonardograsso.com> Signed-off-by: Aizhamal Nurmamat kyzy <aizhamal@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
LGTM label has been added. Git tree hash: 03bc33e75db41d7ae5fcf9db82b23c8cd5cd419a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aijamalnk, FedeDP, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/kind documentation
What this PR does / why we need it:
It updates the branding guidelines to reference the new brand identity page in the website. The designs are shown on the attached file. Thanks!
falco_brand_page (1).pdf