Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Falco branding guidelines #2493

Merged
merged 4 commits into from
May 18, 2023

Conversation

aijamalnk
Copy link
Contributor

@aijamalnk aijamalnk commented Apr 13, 2023

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/kind documentation

What this PR does / why we need it:

It updates the branding guidelines to reference the new brand identity page in the website. The designs are shown on the attached file. Thanks!

falco_brand_page (1).pdf

NONE

Signed-off-by: Aizhamal Nurmamat kyzy <aizhamal@sysdig.com>
@poiana
Copy link
Contributor

poiana commented Apr 13, 2023

Welcome @aijamalnk! It looks like this is your first PR to falcosecurity/falco 🎉

@poiana poiana added the size/M label Apr 13, 2023
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @aijamalnk

Thank you for PR! I've left a suggestion (see below comment).

May you also open the PR on the website for the Falco branding page, please? I guess it would be better to merge both around the same time.

🙏

brand/README.md Show resolved Hide resolved
brand/README.md Outdated Show resolved Hide resolved
@leogr
Copy link
Member

leogr commented Apr 14, 2023

/milestone 0.35.0

@poiana poiana added this to the 0.35.0 milestone Apr 14, 2023
aijamalnk and others added 2 commits April 26, 2023 13:49
Co-authored-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Aizhamal Nurmamat kyzy <aizhamal@google.com>
Signed-off-by: Aizhamal Nurmamat kyzy <aizhamal@sysdig.com>
@poiana poiana added size/XS and removed size/M labels Apr 26, 2023
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Just waiting for https://falco.org/falco-brand to be published

brand/README.md Outdated Show resolved Hide resolved
Adding the proper link to the brand guides

Co-authored-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Aizhamal Nurmamat kyzy <aizhamal@google.com>
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@poiana
Copy link
Contributor

poiana commented May 15, 2023

LGTM label has been added.

Git tree hash: 03bc33e75db41d7ae5fcf9db82b23c8cd5cd419a

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented May 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aijamalnk, FedeDP, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 52fe77c into falcosecurity:master May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants