-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new(ci): add RC/prerelease support #2533
Conversation
Signed-off-by: Luca Guerra <luca@guerra.sh>
12d9714
to
4a65ed1
Compare
/milestone 0.35.0 |
Signed-off-by: Luca Guerra <luca@guerra.sh>
Signed-off-by: Luca Guerra <luca@guerra.sh>
Signed-off-by: Luca Guerra <luca@guerra.sh>
7ddcdf0
to
014b159
Compare
Signed-off-by: Luca Guerra <luca@guerra.sh>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one suggestion (see my comment below). Otherwise SGMT.
Signed-off-by: Luca Guerra <luca@guerra.sh>
Signed-off-by: Luca Guerra <luca@guerra.sh> Co-authored-by: Federico Di Pierro <nierro92@gmail.com>
Signed-off-by: Luca Guerra <luca@guerra.sh> Co-authored-by: Federico Di Pierro <nierro92@gmail.com>
Signed-off-by: Luca Guerra <luca@guerra.sh> Co-authored-by: Federico Di Pierro <nierro92@gmail.com>
35ccac8
to
227252e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM label has been added. Git tree hash: f68c97cbae7c1496b2aebdae1d427c6ecc28b34d
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, leogr, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
/area CI
What this PR does / why we need it:
In this new pipeline we need RC support for several reasons:
How does it work?
Once a maintainer clicks the release button on GitHub a tag is created and a GH release added as well. If the tag name is formatted like
x.y.z
the release is official, also if the "make latest" button is pressed the release is also latest (meaning that the:latest
tag of the container image will be overwritten)If, instead, the tag is formatted as
x.y.z-k
the release is a prerelease. Artifacts will go in the-dev
bucket and the:latest
tag will not be overwritten.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: