Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(ci): add RC/prerelease support #2533

Merged
merged 9 commits into from
May 10, 2023

Conversation

LucaGuerra
Copy link
Contributor

@LucaGuerra LucaGuerra commented May 4, 2023

What type of PR is this?

/kind feature
/area CI

What this PR does / why we need it:

In this new pipeline we need RC support for several reasons:

  • We want to actually publish RCs before release for testing purposes
  • Once we're in the release branch there was no way to test the latest version or to get a working image unless it is already released, which is painful, inconvenient and slows the release process
  • We actually want to test the release flow and any new feature we add before we do an actual release :)

How does it work?

Once a maintainer clicks the release button on GitHub a tag is created and a GH release added as well. If the tag name is formatted like x.y.z the release is official, also if the "make latest" button is pressed the release is also latest (meaning that the :latest tag of the container image will be overwritten)

If, instead, the tag is formatted as x.y.z-k the release is a prerelease. Artifacts will go in the -dev bucket and the :latest tag will not be overwritten.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Luca Guerra <luca@guerra.sh>
@LucaGuerra LucaGuerra force-pushed the new/ci-rc-prerelease branch from 12d9714 to 4a65ed1 Compare May 5, 2023 08:17
.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Show resolved Hide resolved
.github/workflows/release.yaml Show resolved Hide resolved
@FedeDP
Copy link
Contributor

FedeDP commented May 5, 2023

/milestone 0.35.0

@poiana poiana added this to the 0.35.0 milestone May 5, 2023
Signed-off-by: Luca Guerra <luca@guerra.sh>
@poiana poiana added size/L and removed size/M labels May 8, 2023
LucaGuerra added 2 commits May 8, 2023 13:12
Signed-off-by: Luca Guerra <luca@guerra.sh>
@LucaGuerra LucaGuerra force-pushed the new/ci-rc-prerelease branch from 7ddcdf0 to 014b159 Compare May 8, 2023 15:40
@poiana poiana added size/XL and removed size/L labels May 8, 2023
Signed-off-by: Luca Guerra <luca@guerra.sh>
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion (see my comment below). Otherwise SGMT.

RELEASE.md Show resolved Hide resolved
Signed-off-by: Luca Guerra <luca@guerra.sh>
LucaGuerra and others added 3 commits May 10, 2023 08:33
Signed-off-by: Luca Guerra <luca@guerra.sh>
Co-authored-by: Federico Di Pierro <nierro92@gmail.com>
Signed-off-by: Luca Guerra <luca@guerra.sh>
Co-authored-by: Federico Di Pierro <nierro92@gmail.com>
Signed-off-by: Luca Guerra <luca@guerra.sh>
Co-authored-by: Federico Di Pierro <nierro92@gmail.com>
@LucaGuerra LucaGuerra force-pushed the new/ci-rc-prerelease branch from 35ccac8 to 227252e Compare May 10, 2023 08:33
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@poiana
Copy link
Contributor

poiana commented May 10, 2023

LGTM label has been added.

Git tree hash: f68c97cbae7c1496b2aebdae1d427c6ecc28b34d

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!
/approve

@poiana
Copy link
Contributor

poiana commented May 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, leogr, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit f5c7574 into falcosecurity:master May 10, 2023
@LucaGuerra LucaGuerra deleted the new/ci-rc-prerelease branch May 10, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants