Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): get the manifest for the correct tag #2563

Merged
merged 1 commit into from
May 22, 2023
Merged

fix(ci): get the manifest for the correct tag #2563

merged 1 commit into from
May 22, 2023

Conversation

LucaGuerra
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug
/area ci

What this PR does / why we need it:

As per title.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@LucaGuerra
fix(ci): get the manifest for the correct tag
547ab94 
Signed-off-by: Luca Guerra <luca@guerra.sh>
@poiana poiana requested review from Andreagit97 and Kaizhe May 22, 2023 08:24
@poiana poiana added the size/XS label May 22, 2023
FedeDP
FedeDP approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Andreagit97
Andreagit97 approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label May 22, 2023
@poiana
Copy link
Contributor

poiana commented May 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented May 22, 2023

LGTM label has been added.

Git tree hash: 420423490821b79a3c0e0c8209ea9c38155dd84a

@poiana
Copy link
Contributor

poiana commented May 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FedeDP
Copy link
Contributor

FedeDP commented May 22, 2023

/milestone 0.35.0

@poiana poiana added this to the 0.35.0 milestone May 22, 2023
@poiana poiana merged commit f72489e into falcosecurity:master May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andreagit97 Andreagit97 Andreagit97 approved these changes

@FedeDP FedeDP FedeDP approved these changes

@Kaizhe Kaizhe Awaiting requested review from Kaizhe

Assignees

@FedeDP FedeDP

@Andreagit97 Andreagit97

Labels
approved area/ci dco-signoff: yes kind/bug lgtm release-note-none size/XS
Projects
Falco Roadmap
Archived in project
Milestone
0.35.0
Development

Successfully merging this pull request may close these issues.
4 participants
@LucaGuerra @poiana @FedeDP @Andreagit97