-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support reload in falco systemd units #2588
Conversation
/milestone 0.36.0 |
Thank you for this! Since we are very close to the 0.35.0 release, we target this to the 0.36 release! |
we will take a look soon! |
Given the system unit documentation, this seems correct and a nice improvement. |
Signed-off-by: jabdr <jd@q321.de>
Signed-off-by: jabdr <jd@q321.de>
Signed-off-by: jabdr <jd@q321.de>
Signed-off-by: jabdr <jd@q321.de>
Rebased it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice 👍
LGTM label has been added. Git tree hash: 548e35c20cc932db7210a247f6da6b8834fc38e6
|
/hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, jabdr, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
Support easy reload with systemd units
Which issue(s) this PR fixes:
Fixes #2587
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
YES