Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support reload in falco systemd units #2588

Merged
merged 4 commits into from
Aug 30, 2023
Merged

Support reload in falco systemd units #2588

merged 4 commits into from
Aug 30, 2023

Conversation

jabdr
Copy link
Contributor

@jabdr jabdr commented May 25, 2023

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area tests

/area proposals

/area CI

What this PR does / why we need it:
Support easy reload with systemd units

Which issue(s) this PR fixes:

Fixes #2587

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
YES

new: support systemctl reload for Falco services

@poiana poiana requested review from FedeDP and Kaizhe May 25, 2023 15:30
@poiana poiana added the size/XS label May 25, 2023
@FedeDP FedeDP changed the title Support reload in falco-kmod.service Support reload in falco systemd units May 29, 2023
@leogr
Copy link
Member

leogr commented May 29, 2023

/milestone 0.36.0

@poiana poiana added this to the 0.36.0 milestone May 29, 2023
@FedeDP
Copy link
Contributor

FedeDP commented May 29, 2023

Thank you for this! Since we are very close to the 0.35.0 release, we target this to the 0.36 release!

@Andreagit97
Copy link
Member

we will take a look soon!

@FedeDP
Copy link
Contributor

FedeDP commented Aug 29, 2023

ExecReload=

    Commands to execute to trigger a configuration reload in the service. This argument takes multiple command lines, following the same scheme as described for ExecStart= above. Use of this setting is optional. Specifier and environment variable substitution is supported here following the same scheme as for ExecStart=.

    One additional, special environment variable is set: if known, $MAINPID is set to the main process of the daemon, and may be used for command lines like the following:

    ExecReload=kill -HUP $MAINPID

Given the system unit documentation, this seems correct and a nice improvement.
@jabdr Can you rebase on top of master?
Then we will quickly test the feature :)

jabdr added 4 commits August 29, 2023 12:33
Signed-off-by: jabdr <jd@q321.de>
Signed-off-by: jabdr <jd@q321.de>
Signed-off-by: jabdr <jd@q321.de>
Signed-off-by: jabdr <jd@q321.de>
@Andreagit97
Copy link
Member

Rebased it :)

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

@poiana
Copy link
Contributor

poiana commented Aug 29, 2023

LGTM label has been added.

Git tree hash: 548e35c20cc932db7210a247f6da6b8834fc38e6

@Andreagit97
Copy link
Member

/hold

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Aug 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, jabdr, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 66841d8 into falcosecurity:master Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

systemd unit reload
5 participants