update: enforce bumping engine version whenever appropriate #2719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
jasondellaluce
force-pushed
the
update/require-engine-ver-bump
branch
7 times, most recently
from
d679271 to
6aa254a
Compare
|
/milestone 0.36.0 |
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
jasondellaluce
force-pushed
the
update/require-engine-ver-bump
branch
from
6aa254a to
19a3318
Compare
leogr
approved these changes
Aug 4, 2023
|
LGTM label has been added. Git tree hash: 5fe1cfee2982adddb7870a0627718f60f6d74a85
|
Andreagit97
reviewed
Aug 4, 2023
Andreagit97
reviewed
Aug 4, 2023
This is of course a false positive. The checksum is changed just because I changed how it's computed. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, jasondellaluce, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/kind documentation
Any specific area of the project related to this PR?
/area CI
/area build
What this PR does / why we need it:
This follows-up falcosecurity/libs#1273 and follows the same logic, applying it to the Falco engine version.
Accordingly, the formula for updating the engine checksum has been changed for catching more information. Moreover, two CI checks have been added:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: