Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve -p as needed by latest "Style Guide of Falco Rules" #2737

Merged
merged 3 commits into from
Aug 25, 2023

Conversation

leogr
Copy link
Member

@leogr leogr commented Aug 22, 2023

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area tests

/area proposals

/area CI

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #2699

Special notes for your reviewer:

/milestone 0.36.0

cc @incertum

Does this PR introduce a user-facing change?:

update: `-p` presets have been updated to reflect the new rules style guide

@poiana poiana added this to the 0.36.0 milestone Aug 22, 2023
@poiana poiana requested review from FedeDP and Kaizhe August 22, 2023 16:08
@leogr leogr changed the title wip: wip: Improve -p as needed by latest "Style Guide of Falco Rules" Aug 22, 2023
@leogr leogr force-pushed the update/issue/2699 branch from 5dfddc7 to fa985f2 Compare August 22, 2023 16:13
leogr added 2 commits August 22, 2023 18:22
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@leogr leogr force-pushed the update/issue/2699 branch from fa985f2 to be0c06d Compare August 22, 2023 16:23
Co-authored-by: Andrea Terzolo <andrea.terzolo@polito.it>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
i've tested it and it works

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; this is still wip though.
/approve

@poiana
Copy link
Contributor

poiana commented Aug 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,FedeDP,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leogr leogr changed the title wip: Improve -p as needed by latest "Style Guide of Falco Rules" Improve -p as needed by latest "Style Guide of Falco Rules" Aug 25, 2023
@poiana poiana merged commit 84fe33a into master Aug 25, 2023
@poiana poiana deleted the update/issue/2699 branch August 25, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Improve -pk as needed by latest "Style Guide of Falco Rules"
5 participants