-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve -p
as needed by latest "Style Guide of Falco Rules"
#2737
Conversation
-p
as needed by latest "Style Guide of Falco Rules"
5dfddc7
to
fa985f2
Compare
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
fa985f2
to
be0c06d
Compare
Co-authored-by: Andrea Terzolo <andrea.terzolo@polito.it> Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
i've tested it and it works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; this is still wip though.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
-p
as needed by latest "Style Guide of Falco Rules"-p
as needed by latest "Style Guide of Falco Rules"
What type of PR is this?
/kind cleanup
/kind documentation
/kind feature
Any specific area of the project related to this PR?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #2699
Special notes for your reviewer:
/milestone 0.36.0
cc @incertum
Does this PR introduce a user-facing change?: