cleanup(config): assign Stable to base_syscalls config
#2740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Melissa Kilby <melissa.kilby.oss@gmail.com>
incertum
commented
Aug 23, 2023
| @@ -811,7 +811,7 @@ syscall_buf_size_preset: 4 | |||
| # visibility into the system. | |||
| syscall_drop_failed_exit: false | |||
|
|
|||
| # [Experimental] `base_syscalls`, use with caution, read carefully | |||
| # [Stable] `base_syscalls`, use with caution, read carefully | |||
There was a problem hiding this comment.
🎉 @FedeDP @Andreagit97 @jasondellaluce @leogr - Surprisingly no issues wrt base_syscalls since we released it. Have you heard of any outstanding issues? I haven't.
|
/milestone 0.36.0 |
|
LGTM label has been added. Git tree hash: 28b74ea4fa26d9a812ca155b6143b746ae472053
|
Andreagit97
approved these changes
Aug 24, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, incertum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
Assign Stable to
base_syscallsconfig.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: