Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: turn some warnings into errors #2744

Merged
merged 2 commits into from
Aug 29, 2023
Merged

cleanup: turn some warnings into errors #2744

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4deaca6
cleanup: fail if the time unit is not specified
Andreagit97 Aug 29, 2023
3851431
cleanup: turn a warning into an error
Andreagit97 Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions userspace/falco/app/actions/process_events.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,12 +427,12 @@ static falco::app::run_result init_stats_writer(

if(std::all_of(config->m_metrics_interval_str.begin(), config->m_metrics_interval_str.end(), ::isdigit))
{
falco_logger::log(LOG_WARNING, "Metrics interval was passed as numeric value without Prometheus time unit, this option will be deprecated in the future");
return falco::app::run_result::fatal("Metrics interval was passed as numeric value without Prometheus time unit. Please specify a time unit");
}

if (config->m_metrics_enabled && !sw->has_output())
{
falco_logger::log(LOG_WARNING, "Metrics are enabled with no output configured, no snapshot will be collected");
return falco::app::run_result::fatal("Metrics are enabled with no output configured. Please enable at least one output channel");
}

falco_logger::log(LOG_INFO, "Setting metrics interval to " + config->m_metrics_interval_str + ", equivalent to " + std::to_string(config->m_metrics_interval) + " (ms)\n");
Expand Down