Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(docker): use debian 12 slim for falco no driver #2782

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

LucaGuerra
Copy link
Contributor

@LucaGuerra LucaGuerra commented Sep 6, 2023

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind feature
/area build

What this PR does / why we need it:

Since we're updating the large image to Debian 12 I believe it makes sense to update the nodriver one as well. It's also slightly smaller (about ~30MB smaller).

I tested it with the modern eBPF probe and the (previously installed) kernel module.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

update(docker): the Falco no-driver image is now based on Debian 12

Signed-off-by: Luca Guerra <luca@guerra.sh>
@LucaGuerra
Copy link
Contributor Author

/milestone 0.36.0

@poiana poiana added this to the 0.36.0 milestone Sep 6, 2023
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
Love this, thank you Luca!

@poiana
Copy link
Contributor

poiana commented Sep 6, 2023

LGTM label has been added.

Git tree hash: 5f2ed48af86401c28b7825ab51fb0873e95edf1e

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Sep 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit d1b932d into falcosecurity:master Sep 7, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants