update(engine): port decode_uri in falco engine #2912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luca Guerra <luca@guerra.sh>
|
PS: I might as well add a couple tests while I'm at it |
|
This PR may bring feature or behavior changes in the Falco engine and may require the engine version to be bumped. Please double check userspace/engine/falco_engine_version.h file. See versioning for FALCO_ENGINE_VERSION. /hold |
Signed-off-by: Luca Guerra <luca@guerra.sh>
|
Also added a test! /unhold as it does not change engine version |
|
/unhold |
|
LGTM label has been added. Git tree hash: a7881c8d93fcc256d2a7fdb3ef45431f5fd16543
|
|
/milestone 0.37.0 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, incertum, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
Since falcosecurity/libs#1478 , the Falco libs no longer provides the
uriclass. The only functionality that Falco ever needed from there is an utility function to decode an urlencoded string. Port this function to the Falco engine. This is necessary for removal of the legacy metadata/k8s client.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
I don't have a strong opinion about whether this could live in its own
uri.hfile or is fine infalco_utils.h. If anyone has, let me know!Does this PR introduce a user-facing change?: