Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update!: bump libs to latest and deprecation of k8s metadata options and configs #2914

Merged
merged 5 commits into from
Nov 16, 2023

Conversation

jasondellaluce
Copy link
Contributor

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area build

/area engine

What this PR does / why we need it:

This bumps the libs dependency (which we haven't done in a while), and inherently deprecates the -k, -K, --k8s-node options of Falco that are no more functional (alongside all config options related to k8s) as tracked in #2763.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

update!: bump libs to latest and deprecation of k8s metadata options and configs

@jasondellaluce
Copy link
Contributor Author

/milestone 0.37.0

@poiana poiana added this to the 0.37.0 milestone Nov 15, 2023
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
@jasondellaluce jasondellaluce force-pushed the update/bump-libs-driver branch from 6b320ce to 8b84939 Compare November 15, 2023 16:10
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/approve

@@ -170,11 +167,10 @@ rules_file:
#
# Please note that if your intention is to enrich Falco syscall logs with fields
# such as `k8s.ns.name`, `k8s.pod.name`, and `k8s.pod.*`, you do not need to use
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes the container fields will have another name but I will update the doc in another PR

@poiana
Copy link
Contributor

poiana commented Nov 15, 2023

LGTM label has been added.

Git tree hash: e336f48c2e84d8a45cf363e4a32ffc3a664faa09

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Nov 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,FedeDP,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 66a122d into master Nov 16, 2023
22 checks passed
@poiana poiana deleted the update/bump-libs-driver branch November 16, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants