-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update!: bump libs to latest and deprecation of k8s metadata options and configs #2914
Conversation
/milestone 0.37.0 |
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
6b320ce
to
8b84939
Compare
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
/approve
@@ -170,11 +167,10 @@ rules_file: | |||
# | |||
# Please note that if your intention is to enrich Falco syscall logs with fields | |||
# such as `k8s.ns.name`, `k8s.pod.name`, and `k8s.pod.*`, you do not need to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes the container fields will have another name but I will update the doc in another PR
LGTM label has been added. Git tree hash: e336f48c2e84d8a45cf363e4a32ffc3a664faa09
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, jasondellaluce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area build
/area engine
What this PR does / why we need it:
This bumps the libs dependency (which we haven't done in a while), and inherently deprecates the
-k
,-K
,--k8s-node
options of Falco that are no more functional (alongside all config options related to k8s) as tracked in #2763.Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: