Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(userspace): enhancements in rule description feature #2934

Merged
merged 4 commits into from
Dec 2, 2023

Conversation

jasondellaluce
Copy link
Contributor

What type of PR is this?

/kind cleanup

/kind feature

Any specific area of the project related to this PR?

/area engine

What this PR does / why we need it:

Which issue(s) this PR fixes:

This mostly involves Falco -L, and the engine in general, from different fronts:

  • Uniform usage of nlohmann::json instead of alternating it with jsoncpp -- we may be on the road for avoid having two json libs in the project
  • Avoiding memory copies wherever possible
  • The stdout printout is not taken care of by the Falco app and not the engine, for better separation of concerns
  • Falco -L now can be used in combination with -V for parity, given that it was already compatible with -r, also enabling the feature of validating a ruleset and showing its internals all in a single step

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

update(userspace): enhancements in rule description feature

@jasondellaluce
Copy link
Contributor Author

/milestone 0.37.0

@poiana poiana added this to the 0.37.0 milestone Nov 29, 2023
@poiana poiana added the size/XL label Nov 29, 2023
Copy link

This PR may bring feature or behavior changes in the Falco engine and may require the engine version to be bumped.

Please double check userspace/engine/falco_engine_version.h file. See versioning for FALCO_ENGINE_VERSION.

/hold

@jasondellaluce jasondellaluce force-pushed the update/description-enhancements branch from cba88da to 2b38a5b Compare November 29, 2023 15:03
@jasondellaluce
Copy link
Contributor Author

This PR may bring feature or behavior changes in the Falco engine and may require the engine version to be bumped.

This is a false positive IMO, no feature of the language or engine is altered.

/unhold

Copy link
Contributor

@incertum incertum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Nov 29, 2023

LGTM label has been added.

Git tree hash: 18ab6c34944f1c2ee7867428b135b012318afe1e

… not print from engine

Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
incertum
incertum previously approved these changes Dec 1, 2023
Copy link
Contributor

@incertum incertum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Dec 1, 2023
@poiana
Copy link
Contributor

poiana commented Dec 1, 2023

LGTM label has been added.

Git tree hash: a8e407571eb4e79214c0f4fdd36e37271b4ec173

Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Dec 1, 2023

LGTM label has been added.

Git tree hash: cbfce3925c3f5f5ae38e5041b9313783eeead502

Copy link
Contributor

@incertum incertum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Dec 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, incertum, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,incertum,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 305ed75 into master Dec 2, 2023
22 checks passed
@poiana poiana deleted the update/description-enhancements branch December 2, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants