refactor: cleanup libs relative include paths #2936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR may bring feature or behavior changes in the Falco engine and may require the engine version to be bumped. Please double check userspace/engine/falco_engine_version.h file. See versioning for FALCO_ENGINE_VERSION. /hold |
therealbobo
force-pushed
the
cleanup-relative-import-paths
branch
2 times, most recently
from
e5323a6 to
8421b6e
Compare
therealbobo
changed the title
therealbobo
force-pushed
the
cleanup-relative-import-paths
branch
from
8421b6e to
566d582
Compare
|
LGTM label has been added. Git tree hash: 935f80326f2089591a4941f8bf5ea8797626b640
|
|
There already is a /hold just in case since we tagged it as Falco 0.38 |
|
Could we get a rebase? Thanks! |
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
therealbobo
dismissed stale reviews from incertum and Andreagit97
via
647968a
therealbobo
force-pushed
the
cleanup-relative-import-paths
branch
from
566d582 to
647968a
Compare
|
LGTM label has been added. Git tree hash: ae432501f895bdb67d55195a94ade5a7cc44f72e
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, incertum, therealbobo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
poiana
added
release-note-none
and removed
do-not-merge/release-note-label-needed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
What this PR does / why we need it:
This updates the include paths of libs. The motivation behind this is to improve readability of the code and provide a more explicit and organized structure for including header files owned by libs.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This depends on falcosecurity/libs#1509.
Does this PR introduce a user-facing change?: