Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): remove outdated development libs #2946

Conversation

federico-sysdig
Copy link
Contributor

@federico-sysdig federico-sysdig commented Dec 5, 2023

What type of PR is this?
/kind cleanup

Any specific area of the project related to this PR?
/area build

What this PR does / why we need it:
The change removes all leftover traces of these libraries, no longer used in falcosecurity/libs or in this project.

  • b64
  • libyaml (note: this is different from libyaml-cpp, still in usage)
  • tinydir
  • libjq

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Federico Aponte <federico.aponte@sysdig.com>
@poiana
Copy link
Contributor

poiana commented Dec 5, 2023

Welcome @federico-sysdig! It looks like this is your first PR to falcosecurity/falco 🎉

@poiana poiana requested review from Andreagit97 and Kaizhe December 5, 2023 22:17
@poiana poiana added the size/M label Dec 5, 2023
Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Dec 5, 2023

LGTM label has been added.

Git tree hash: f1d2c7a06c5e2f6b6c94808353f58651c8021b59

@poiana poiana added the approved label Dec 5, 2023
Copy link
Contributor

@incertum incertum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Dec 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: federico-sysdig, incertum, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [incertum,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit e558c4f into falcosecurity:master Dec 6, 2023
20 checks passed
@Andreagit97 Andreagit97 added this to the 0.37.0 milestone Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants