Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): revert #2961. #2984

Merged
merged 1 commit into from
Dec 20, 2023
Merged

chore(ci): revert #2961. #2984

merged 1 commit into from
Dec 20, 2023

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Dec 20, 2023

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area CI

What this PR does / why we need it:

It seems like falco driver loader integration tests do not work reliably on actuated arm64 node, even if:

  • manually ssh-ing inside the node and running the tests works fine
  • trying the tests on an ec2 arm64 node runs fine

See #2979 with lots of tests.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP
Copy link
Contributor Author

FedeDP commented Dec 20, 2023

/milestone 0.37.0

@poiana poiana added this to the 0.37.0 milestone Dec 20, 2023
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Dec 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,FedeDP,LucaGuerra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit a2c128e into master Dec 20, 2023
28 checks passed
@poiana poiana deleted the chore/revert_2961 branch December 20, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants