fix: adopt new libsinsp logger #3026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM label has been added. Git tree hash: b3600a1ec89c5741f8e364c9d949ff4a092e8feb
|
|
/hold |
|
before this, we need to bump Falco to the latest libs commit |
|
/milestone 0.38.0 |
|
Could we take care of this next? To make Falco compatible with current libs master? |
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
therealbobo
force-pushed
the
new-logger
branch
from
7949bd4 to
49606e8
Compare
|
LGTM label has been added. Git tree hash: eb9c08269743b4669f1e6f4551bea0dea42a7c9e
|
poiana
added
release-note-none
and removed
do-not-merge/release-note-label-needed
labels
|
Engine checksum must be updated ;) |
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
|
@therealbobo the checksum change must also include a version bump |
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
|
LGTM label has been added. Git tree hash: e2fcbd020628790f6971e359b3b6415703233420
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, incertum, jasondellaluce, therealbobo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
What this PR does / why we need it:
This adopts the new logger from libs.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: