Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(release): merge 2 PRs into release 0.37.x #3031

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Jan 23, 2024

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

What this PR does / why we need it:

Cherry picks #3030 and #3028 from master.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

FedeDP and others added 3 commits January 23, 2024 11:58
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
@FedeDP FedeDP changed the base branch from master to release/0.37.x January 23, 2024 11:00
@poiana poiana added the size/M label Jan 23, 2024
@poiana poiana requested review from incertum and Kaizhe January 23, 2024 11:00
Copy link

This PR may bring feature or behavior changes in the Falco engine and may require the engine version to be bumped.

Please double check userspace/engine/falco_engine_version.h file. See versioning for FALCO_ENGINE_VERSION.

/hold

@FedeDP
Copy link
Contributor Author

FedeDP commented Jan 23, 2024

/milestone 0.37.0

@poiana poiana added this to the 0.37.0 milestone Jan 23, 2024
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jan 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,FedeDP,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FedeDP
Copy link
Contributor Author

FedeDP commented Jan 23, 2024

/unhold

@poiana poiana merged commit 102e497 into release/0.37.x Jan 23, 2024
30 checks passed
@poiana poiana deleted the update/release_0.37.x branch January 23, 2024 11:30
@Andreagit97 Andreagit97 mentioned this pull request Jan 24, 2024
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants