Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(build): link libelf dynamically #3048

Merged
merged 8 commits into from
Feb 2, 2024

Conversation

LucaGuerra
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

What this PR does / why we need it:

As per title. The Falco default build will now dynamically link libelf.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

update(build): link libelf dynamically

Signed-off-by: Luca Guerra <luca@guerra.sh>
Signed-off-by: Luca Guerra <luca@guerra.sh>
@poiana poiana requested a review from Kaizhe January 31, 2024 17:01
@poiana poiana requested a review from leogr January 31, 2024 17:01
@LucaGuerra LucaGuerra changed the title new(build): build libelf dynamically new(build): link libelf dynamically Jan 31, 2024
@LucaGuerra LucaGuerra changed the title new(build): link libelf dynamically wip: new(build): link libelf dynamically Jan 31, 2024
@LucaGuerra
Copy link
Contributor Author

The CI will need to be updated accordingly. I am using this PR to work on that and make sure the CI is happy

Signed-off-by: Luca Guerra <luca@guerra.sh>
… installed

Signed-off-by: Luca Guerra <luca@guerra.sh>
Signed-off-by: Luca Guerra <luca@guerra.sh>
@LucaGuerra LucaGuerra force-pushed the new/build-shared-libelf branch from 1e95c2b to 38a71b0 Compare February 2, 2024 10:55
@poiana poiana added size/M and removed size/S labels Feb 2, 2024
Signed-off-by: Luca Guerra <luca@guerra.sh>
@LucaGuerra LucaGuerra force-pushed the new/build-shared-libelf branch 2 times, most recently from 68a9b09 to caa02ce Compare February 2, 2024 15:16
Signed-off-by: Luca Guerra <luca@guerra.sh>
@LucaGuerra LucaGuerra force-pushed the new/build-shared-libelf branch from caa02ce to 523d825 Compare February 2, 2024 15:19
Signed-off-by: Luca Guerra <luca@guerra.sh>
@LucaGuerra LucaGuerra changed the title wip: new(build): link libelf dynamically new(build): link libelf dynamically Feb 2, 2024
Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Feb 2, 2024

LGTM label has been added.

Git tree hash: f486a1a1a21e57b579a3c8ba39e9acf03ca3a1f0

@poiana
Copy link
Contributor

poiana commented Feb 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasondellaluce, leogr, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [LucaGuerra,jasondellaluce,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit ea67e47 into falcosecurity:master Feb 2, 2024
29 checks passed
@LucaGuerra LucaGuerra deleted the new/build-shared-libelf branch February 5, 2024 08:32
@FedeDP
Copy link
Contributor

FedeDP commented Feb 8, 2024

/milestone 0.37.1

@poiana poiana added this to the 0.37.1 milestone Feb 8, 2024
@FedeDP FedeDP mentioned this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants