added option for insecure http driver download #3058
Conversation
Added option for insecure http driver download in the docker-entrypoint.sh script. By passing --http-insecure to the container via an argument, the flag is forwarded to the falcoctl driver install command. Signed-off-by: Tom Müller <60851960+toamto94@users.noreply.github.com>
|
Welcome @toamto94! It looks like this is your first PR to falcosecurity/falco 🎉 |
|
/assign |
|
Thanks for this PR! Can you add the same code to driver-loader-legacy and Falco images entrypoints? |
|
Btw sorry, I completely forgot to add the option back in the 0.37.0 dev cycle! |
Of course! I will quickly add it |
added insecure http driver download to the driver-loader-legacy entrypoint. Signed-off-by: Tom Müller <60851960+toamto94@users.noreply.github.com>
added option for insecure http driver download to the falco docker entrypoint. Signed-off-by: Tom Müller <60851960+toamto94@users.noreply.github.com>
fixed typo in the print usage description of the docker run command Signed-off-by: Tom Müller <60851960+toamto94@users.noreply.github.com>
|
@FedeDP Code is added. First added a typo do the description of the docker command in the legacy script but this fixed as well now |
|
LGTM label has been added. Git tree hash: 21c79530ffa9c83337ec54e74afb6a2df24a8263
|
|
/milestone 0.38.0 Might be ported into a 0.37.1 patch release, if needed. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, toamto94 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/milestone 0.37.1 |
Added option for insecure http driver download in the docker-entrypoint.sh script. By passing --http-insecure to the container via an argument, the flag is forwarded to the falcoctl driver install command.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area proposals
What this PR does / why we need it:
Adds a simple functionality to the driverbuilder script which has not been enabled before
Which issue(s) this PR fixes:
Feature has been available until the migration from script based driver build to falcoctl based one.
Fixes #3057
Special notes for your reviewer:
Simply adds a flag that is forwarded
Does this PR introduce a user-facing change?:
No, everythin works as before and the default of the flag is false anyway