Cleanup variable use #3097
Merged
Cleanup variable use #3097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Samuel Gaist <samuel.gaist@idiap.ch>
Signed-off-by: Samuel Gaist <samuel.gaist@idiap.ch>
When hitting that part, the restart signal is triggered and the code leaves the loop, hence setting should_restart as false makes no sense in this context. Signed-off-by: Samuel Gaist <samuel.gaist@idiap.ch>
|
/milestone 0.38.0 |
|
LGTM label has been added. Git tree hash: 665f81d8ed18c5d0f0b0fdc1ac59809072ce7f21
|
|
Btw just wanted to thank you for the effort you are putting in this! We really needed this sort of cleanups on Falco. |
LucaGuerra
approved these changes
Feb 19, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, LucaGuerra, sgaist The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area engine
/area tests
What this PR does / why we need it:
This PR removes unused or unread variables. The former are variables declared but not initialized and the latter are initialized but both are not used or assigned but the new value is not used.
Reported by cppcheck.
Which issue(s) this PR fixes:
Fixes #3096
Special notes for your reviewer:
Does this PR introduce a user-facing change?: