Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(submodules): dropped testing submodule. #3098

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Feb 19, 2024

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area build

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP FedeDP force-pushed the cleanup/drop_testing_submodule branch from a88d020 to c38a0af Compare February 19, 2024 10:28
@FedeDP
Copy link
Contributor Author

FedeDP commented Feb 19, 2024

/milestone 0.38.0

@poiana poiana added this to the 0.38.0 milestone Feb 19, 2024
@FedeDP
Copy link
Contributor Author

FedeDP commented Feb 19, 2024

/cc @jasondellaluce

Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Feb 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, jasondellaluce, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [FedeDP,jasondellaluce,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 1178a05 into master Feb 19, 2024
27 checks passed
@poiana poiana deleted the cleanup/drop_testing_submodule branch February 19, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants