Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmake): properly let falcoctl cmake module create /usr/share/falco/plugins/ folder. #3105

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Feb 20, 2024

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area build

What this PR does / why we need it:

#2997 dropped bundled plugins; but we still need to create /usr/share/falco/plugins folder to allow falcoctl to correctly work.

Which issue(s) this PR fixes:

Fixes #3103

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix(cmake): properly let falcoctl cmake module create /usr/share/falco/plugins/ folder.

…co/plugins/` folder.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP
Copy link
Contributor Author

FedeDP commented Feb 20, 2024

/milestone 0.38.0

@poiana poiana added this to the 0.38.0 milestone Feb 20, 2024
@poiana poiana requested review from Kaizhe and mstemm February 20, 2024 15:51
@FedeDP
Copy link
Contributor Author

FedeDP commented Feb 20, 2024

Tested locally:

-- Installing: /usr/local/share/falco/plugins

@FedeDP
Copy link
Contributor Author

FedeDP commented Feb 20, 2024

Note: we might want to drop this line from testing repo composite action: https://github.com/falcosecurity/testing/blob/main/action.yml#L65
Might help us spot regressions in the future (interesting fact: i added that line to fix failing tests in #2997... there is no limit to human stupidity 🤣 )

EDIT: in case we drop the line, tests against 0.37.0 and 0.37.1 would fail though.

Copy link
Contributor

@incertum incertum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@FedeDP don't blame yourself seriously! re https://github.com/falcosecurity/testing/blob/main/action.yml#L65 could we add a transition pipeline? Because yes I would remove that line to avoid future regressions.

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Feb 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, incertum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,FedeDP,incertum]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 71a0d0d into master Feb 21, 2024
27 checks passed
@poiana poiana deleted the fix/create_plugins_folder branch February 21, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

falcoctl-artifact-follow.service crashes after RPM based install
4 participants