-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cmake): properly let falcoctl cmake module create /usr/share/falco/plugins/
folder.
#3105
Conversation
…co/plugins/` folder. Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
/milestone 0.38.0 |
Tested locally:
|
Note: we might want to drop this line from testing repo composite action: https://github.com/falcosecurity/testing/blob/main/action.yml#L65 EDIT: in case we drop the line, tests against 0.37.0 and 0.37.1 would fail though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
@FedeDP don't blame yourself seriously! re https://github.com/falcosecurity/testing/blob/main/action.yml#L65 could we add a transition pipeline? Because yes I would remove that line to avoid future regressions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, incertum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
#2997 dropped bundled plugins; but we still need to create
/usr/share/falco/plugins
folder to allowfalcoctl
to correctly work.Which issue(s) this PR fixes:
Fixes #3103
Special notes for your reviewer:
Does this PR introduce a user-facing change?: