Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup warnings and smart ptrs #3112

Merged

Conversation

federico-sysdig
Copy link
Contributor

What type of PR is this?
/kind cleanup

Any specific area of the project related to this PR?
/area build

What this PR does / why we need it:
This is just a cleanup/refactor on some usages of smart pointers, plus a fix for a warning about a pessimizing std::move raised by Clang.
The changes might seem very diverse, but they are very simple and arranged into separate commits if the reviewer prefers to address the task for each topic separately.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Copy link

This PR may bring feature or behavior changes in the Falco engine and may require the engine version to be bumped.

Please double check userspace/engine/falco_engine_version.h file. See versioning for FALCO_ENGINE_VERSION.

/hold

Signed-off-by: Federico Aponte <federico.aponte@sysdig.com>
Signed-off-by: Federico Aponte <federico.aponte@sysdig.com>
Signed-off-by: Federico Aponte <federico.aponte@sysdig.com>
Signed-off-by: Federico Aponte <federico.aponte@sysdig.com>
Signed-off-by: Federico Aponte <federico.aponte@sysdig.com>
Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Feb 26, 2024

LGTM label has been added.

Git tree hash: 2046d5313decbb1d001fbc7a629c424e8f638891

@FedeDP
Copy link
Contributor

FedeDP commented Feb 26, 2024

/milestone 0.38.0
/hold
Since ci is failing.

@poiana poiana added this to the 0.38.0 milestone Feb 26, 2024
@FedeDP
Copy link
Contributor

FedeDP commented Feb 26, 2024

/hold

@poiana
Copy link
Contributor

poiana commented Feb 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: federico-sysdig, jasondellaluce, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [LucaGuerra,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@LucaGuerra
Copy link
Contributor

Thanks @FedeDP ! Let's see why the CI has some problems (might be a job config)

@FedeDP
Copy link
Contributor

FedeDP commented Feb 26, 2024

/unhold
CI is unrelated.

@poiana poiana merged commit f6af72f into falcosecurity:master Feb 26, 2024
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants