Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(scripts/falcoctl): bump falco-rules version to 3 #3128

Merged

Conversation

alacuku
Copy link
Member

@alacuku alacuku commented Mar 5, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area tests

/area proposals

/area CI

What this PR does / why we need it:

This PR bumps the version of the falco rules installed by falcoctl when using the deb/rpm packages.

Which issue(s) this PR fixes:

falco-rules:0 lacks the signature, causing falcoctl to fail during the installation process.

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Aldo Lacuku <aldo@lacuku.eu>
@alacuku
Copy link
Member Author

alacuku commented Mar 5, 2024

See: falcosecurity/falcoctl#459

@Andreagit97 Andreagit97 added this to the 0.38.0 milestone Mar 5, 2024
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Mar 5, 2024

LGTM label has been added.

Git tree hash: 77cfd01136753dd306bc0549adb35181e92ccac7

@poiana poiana added the approved label Mar 5, 2024
Copy link
Contributor

@incertum incertum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Mar 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alacuku, Andreagit97, incertum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,incertum]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 185075b into falcosecurity:master Mar 6, 2024
27 checks passed
@LucaGuerra LucaGuerra changed the title update(scrips/falcoctl): bump falco-rules version to 3 update(scripts/falcoctl): bump falco-rules version to 3 May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants