Add --kernelversion and --kernelrelease options to falco driver loader entrypoint #3143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trypoint Signed-off-by: Paul Rey <contact@paulrey.io>
|
Welcome @Sryther! It looks like this is your first PR to falcosecurity/falco 🎉 |
Sryther
changed the title
FedeDP
reviewed
Mar 19, 2024
| @@ -109,9 +121,6 @@ while test $# -gt 0; do | |||
| shift | |||
| done | |||
|
|
|||
| if [ -z "$has_opts" ]; then | |||
FedeDP
reviewed
Mar 19, 2024
| ENABLE_COMPILE="true" | ||
| ENABLE_DOWNLOAD="true" | ||
| fi | ||
| echo "Extra args: $extra_args" |
There was a problem hiding this comment.
I think this is a debug echo right? We can drop it!
Remove debug log Set default option ENABLE_COMPILE and ENABLE_DOWNLOAD Signed-off-by: Paul Rey <contact@paulrey.io>
|
LGTM label has been added. Git tree hash: d7c1f9972c8abf9a301a126428f6f67340569a48
|
|
/milestone 0.38.0 |
FedeDP
reviewed
Mar 21, 2024
The option is supported anymore in falcoctl Signed-off-by: Paul Rey <contact@paulrey.io>
|
LGTM label has been added. Git tree hash: bc8734ace1227d7e2da058aba0947986d9bbac12
|
leogr
approved these changes
Mar 22, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, leogr, Sryther The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
poiana
added
release-note-none
and removed
do-not-merge/release-note-label-needed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area proposals
What this PR does / why we need it:
Automatic detection of Kernel version and Kernel release can be wrong in various cases. This PR aims to give access to falcoctl options already available when running falco-driver-loader in a sidecar.
Special notes for your reviewer:
None.
Does this PR introduce a user-facing change?: