Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmake): fix USE_BUNDLED_DEPS=ON and BUILD_FALCO_UNIT_TESTS=ON #3146

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

LucaGuerra
Copy link
Contributor

@LucaGuerra LucaGuerra commented Mar 25, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

What this PR does / why we need it:

Build was failing when both USE_BUNDLED_DEPS=ON and BUILD_FALCO_UNIT_TESTS=ON were enabled at the same time with linking errors on absl and grpc. This fixes it by reintroducing explicit library linking for the test suite. It is not 100% clear to me why we need this line but I noticed that before this patch the following files would not be linked in the final executable, hence the errors:

../_deps/yamlcpp-build/libyaml-cppd.a
../grpc-prefix/src/grpc/libgrpc++.a
../grpc-prefix/src/grpc/libgrpc.a
../grpc-prefix/src/grpc/libgpr.a
../protobuf-prefix/src/protobuf/target/lib/libprotobuf.a
../c-ares-prefix/src/c-ares/target/lib/libcares.a
../openssl-prefix/src/openssl/target/lib/libssl.a
../openssl-prefix/src/openssl/target/lib/libcrypto.a

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Luca Guerra <luca@guerra.sh>
@LucaGuerra
Copy link
Contributor Author

/milestone 0.38.0

@poiana poiana added this to the 0.38.0 milestone Mar 25, 2024
@LucaGuerra
Copy link
Contributor Author

cc @federico-sysdig

Copy link
Contributor

@federico-sysdig federico-sysdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (as agreed, for now 😁)
I'm curious to dig deeper into this when I get a chance to understand why we need to get the linked libraries of a target we already link to and link those dependencies once more. The sole exercise to write this down in words is confusing.

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Mar 25, 2024

LGTM label has been added.

Git tree hash: 829657f76edca535fc9f6a8ba474ea11ed4b7222

@poiana
Copy link
Contributor

poiana commented Mar 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, jasondellaluce, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [FedeDP,LucaGuerra,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 8421e4b into falcosecurity:master Mar 25, 2024
27 checks passed
@LucaGuerra LucaGuerra deleted the fix/unit_test_bundled_deps branch March 25, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants