-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cmake): fix USE_BUNDLED_DEPS=ON and BUILD_FALCO_UNIT_TESTS=ON #3146
fix(cmake): fix USE_BUNDLED_DEPS=ON and BUILD_FALCO_UNIT_TESTS=ON #3146
Conversation
Signed-off-by: Luca Guerra <luca@guerra.sh>
60cd421
to
c83ba9e
Compare
/milestone 0.38.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (as agreed, for now 😁)
I'm curious to dig deeper into this when I get a chance to understand why we need to get the linked libraries of a target we already link to and link those dependencies once more. The sole exercise to write this down in words is confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 829657f76edca535fc9f6a8ba474ea11ed4b7222
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, jasondellaluce, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
Build was failing when both
USE_BUNDLED_DEPS=ON
andBUILD_FALCO_UNIT_TESTS=ON
were enabled at the same time with linking errors onabsl
andgrpc
. This fixes it by reintroducing explicit library linking for the test suite. It is not 100% clear to me why we need this line but I noticed that before this patch the following files would not be linked in the final executable, hence the errors:Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: