Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(cmake): bump falcoctl to v0.8.0-rc4 #3191

Merged
merged 2 commits into from
May 13, 2024
Merged

update(cmake): bump falcoctl to v0.8.0-rc4 #3191

merged 2 commits into from
May 13, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented May 10, 2024

What type of PR is this?

/kind release

Any specific area of the project related to this PR?

/area build

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP
Copy link
Contributor Author

FedeDP commented May 10, 2024

/milestone 0.38.0

@poiana poiana added this to the 0.38.0 milestone May 10, 2024
incertum
incertum previously approved these changes May 10, 2024
Copy link
Contributor

@incertum incertum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

leogr
leogr previously approved these changes May 10, 2024
@FedeDP
Copy link
Contributor Author

FedeDP commented May 10, 2024

CI Build / test-dev-packages / test-packages (pull_request) Failing after 4m

The test is failing because new falcoctl (v0.8.0-rc3) uses new strings when eBPF and kmod gets compiled, while testing framework expects a generic Driver built. string.
Also, kmod building is failing because a fix is needed on driverkit and needs to be ported back to falcoctl (v0.8.0-rc4 i assume).
/hold
Will bump to falcoctl 0.8.0-rc4 once it's ready.

@FedeDP
Copy link
Contributor Author

FedeDP commented May 10, 2024

Opened driverkit PR: falcosecurity/driverkit#343

@FedeDP FedeDP changed the title update(cmake): bump falcoctl to v0.8.0-rc3 update(cmake): bump falcoctl to v0.8.0-rc4 May 13, 2024
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP FedeDP dismissed stale reviews from leogr and incertum via 786e306 May 13, 2024 07:08
@FedeDP
Copy link
Contributor Author

FedeDP commented May 13, 2024

TestFalco_Legacy_KernelUpgrade test is failing; but there is no error log (neithjer in the uploaded report artifact).
I cannot repro it locally both with a Falco built from this branch and from the uploaded tar.gz artifact:

./build/falco.test -falco-binary /home/federico/Scaricati/falco-0.38.0-249+c54c6dd-x86_64/usr/bin/falco -falco-config /home/federico/Scaricati/falco-0.38.0-249+c54c6dd-x86_64/etc/falco/falco.yaml -test.run TestFalco_Legacy_KernelUpgrade -test.v  
=== RUN   TestFalco_Legacy_KernelUpgrade
=== PAUSE TestFalco_Legacy_KernelUpgrade
=== CONT  TestFalco_Legacy_KernelUpgrade
{"deadline":180000000000,"level":"info","msg":"running falco with runner","time":"2024-05-13T10:00:03+02:00"}
{"cmd":"/home/federico/Scaricati/falco-0.38.0-249+c54c6dd-x86_64/usr/bin/falco -c /home/federico/Scaricati/falco-0.38.0-249+c54c6dd-x86_64/etc/falco/falco.yaml -o json_output=true -r falco_rules.yaml -o engine.kind=replay -o engine.replay.capture_file=kernel-upgrade.scap -o json_include_output_property=false -o json_include_tags_property=false -o log_level=debug -o log_stderr=true -o log_syslog=false -o stdout_output.enabled=true","level":"debug","msg":"executing command","time":"2024-05-13T10:00:03+02:00"}
--- PASS: TestFalco_Legacy_KernelUpgrade (3.93s)
PASS

@FedeDP
Copy link
Contributor Author

FedeDP commented May 13, 2024

For completeness, i also tried to run the same test passing the LSAN_OPTIONS that we also specify in our reusable workflow: https://github.com/falcosecurity/falco/blob/master/.github/workflows/reusable_test_packages.yaml#L56C11-L56C23

Still success.

@FedeDP
Copy link
Contributor Author

FedeDP commented May 13, 2024

/unhold

Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

@incertum incertum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented May 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, incertum, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [FedeDP,incertum,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 44c275d into master May 13, 2024
62 of 63 checks passed
@poiana poiana deleted the update/falcoctl branch May 13, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants