Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the OpenSSF Scorecard Badge #3250

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

harshitasao
Copy link
Contributor

@harshitasao harshitasao commented Jun 13, 2024

What type of PR is this?

/kind documentation

What this PR does / why we need it:
This PR adds OpenSSF Scorecard Badge in the README file.

The project already has the Scorecard GitHub Action running, so adding the scorecard badge would be quite handy. So that the results can be shown as a badge in the repository's README. This badge serves as a quick indicator of the project's security posture, helping users and contributors evaluate the project's security practices quickly.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer: N/A

Does this PR introduce a user-facing change?: N/A

NONE

Signed-off-by: harshitasao <harshitasao@gmail.com>
@poiana
Copy link
Contributor

poiana commented Jun 13, 2024

Welcome @harshitasao! It looks like this is your first PR to falcosecurity/falco 🎉

@LucaGuerra
Copy link
Contributor

Thank you! I have just a question, if you look at the preview this OpenSSF badge style looks different from the other OpenSSF badge we already have, is it possible to apply the same style to both? Thanks!

@FedeDP
Copy link
Contributor

FedeDP commented Jun 18, 2024

/milestone 0.39.0

@poiana poiana added this to the 0.39.0 milestone Jun 18, 2024
@leogr
Copy link
Member

leogr commented Jun 25, 2024

Thank you! I have just a question, if you look at the preview this OpenSSF badge style looks different from the other OpenSSF badge we already have, is it possible to apply the same style to both? Thanks!

I guess we have just to add style=for-the-badge

@harshitasao could you address that please? 🙏

Signed-off-by: harshitasao <harshitasao@gmail.com>
@harshitasao
Copy link
Contributor Author

Sorry for the delay. I have styled the badge as mentioned and converted the scorecard link from JSON to Standard (human readable) format.

Copy link
Contributor

@LucaGuerra LucaGuerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@poiana
Copy link
Contributor

poiana commented Jul 2, 2024

LGTM label has been added.

Git tree hash: c40492878062519acdc0bbfbd0d1a400b5b3facf

@poiana poiana added the approved label Jul 2, 2024
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jul 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, harshitasao, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit c25ded8 into falcosecurity:master Jul 2, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants