Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(cmake,userspace): bump libs and driver to latest master. #3263

Merged
merged 3 commits into from
Jun 26, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Jun 25, 2024

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area build

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Also, this PR cherrypicks 7efabb7 from release/0.38.x branch.

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP
Copy link
Contributor Author

FedeDP commented Jun 25, 2024

/milestone 0.39.0

@poiana poiana added this to the 0.39.0 milestone Jun 25, 2024
@poiana poiana added the size/M label Jun 25, 2024
FedeDP added 2 commits June 25, 2024 14:40
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP
Copy link
Contributor Author

FedeDP commented Jun 25, 2024

Seems like we have a failing test:

  TestFalco_Legacy_NonSudoSetuid

    legacy_test.go:2631: 
        	Error Trace:	/home/runner/actions-runner/_work/_actions/falcosecurity/testing/main/legacy_test.go:2631
        	Error:      	Should be zero, but was 1
        	Test:       	TestFalco_Legacy_NonSudoSetuid

Rule is: https://github.com/falcosecurity/testing/blob/main/tests/data/rules/legacy.go#L2334 and it seems like the test expects no event triggered, instead we are triggering one.

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jun 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,FedeDP,LucaGuerra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 4a4ed1e into master Jun 26, 2024
35 checks passed
@poiana poiana deleted the update/libs branch June 26, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants