Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vote: add sgaist to OWNERS #3264

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Conversation

sgaist
Copy link
Contributor

@sgaist sgaist commented Jun 26, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area tests

/area proposals

/area CI

What this PR does / why we need it:

As discussed during the community call, this follows the process to become part of the maintainers of falco.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Samuel Gaist <samuel.gaist@idiap.ch>
@incertum
Copy link
Contributor

Big +1 from my side ❤️

Samuel has been helping us tremendously over the past ~7 months, most notably in the following areas:

  • Falco outputs
  • C++ coding standards / style / hygiene
  • Falco metrics Prometheus support
  • PR reviews
  • General technical guidance

Thrilled to have you officially onboard as core maintainer. Enjoy the ride 🙃!

@sgaist sgaist changed the title vote: request to join maintainers vote: add sgaist to OWNERS Jun 26, 2024
@FedeDP
Copy link
Contributor

FedeDP commented Jun 27, 2024

Big +1 from me! He already proved to be able to easily scale on the project and contributed many improvements and worked with Melissa on the new metrics framework.
We need people like you :)
Also, he doesn't mind writing good C++ code and that alone is worth it 😆

@leogr
Copy link
Member

leogr commented Jun 27, 2024

Big 👍 from me, too. I second what Melissa and Fede already wrote. Also, I want to thank you again for the significant contributions you have made in the last few months.

@Andreagit97
Copy link
Member

+1! Welcome on board 🚀!

@LucaGuerra
Copy link
Contributor

+1! 🚀

@jasondellaluce
Copy link
Contributor

Definitely +1!

@poiana poiana added the lgtm label Jul 8, 2024
@poiana
Copy link
Contributor

poiana commented Jul 8, 2024

LGTM label has been added.

Git tree hash: 5bb103a9ea4dd3ef29aee4dbea5f227981f92741

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jul 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, jasondellaluce, leogr, sgaist

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [FedeDP,jasondellaluce,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leogr
Copy link
Member

leogr commented Jul 8, 2024

/verify-owners

@poiana poiana merged commit 0e0428c into falcosecurity:master Jul 8, 2024
32 of 34 checks passed
@Andreagit97 Andreagit97 added this to the 0.39.0 milestone Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

8 participants