-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed the token-permission and pinned-dependencies issue #3299
Conversation
Signed-off-by: harshitasao <harshitasao@gmail.com>
/milestone 0.39.0 |
Signed-off-by: harshitasao <harshitasao@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, harshitasao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: b23686b642e23ec0fd0ddab9830f650f75d1b07d
|
/unhold |
cc @sgaist care to re-review? :D |
@FedeDP AFAICT, there's still the |
@sgaist i double checked and it seems reverted to me! Am I missing anything? 😆 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, I mixed that with the actions-github-release version.
This PR broke master CI triggering :/ don't know why. |
/area CI
What this PR does / why we need it:
fixed the token-permission and pinned-dependencies issue which are reported by scorecard.
Which issue(s) this PR fixes:
Part of #3297
Special notes for your reviewer:
Does this PR introduce a user-facing change?: