-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new(falco): enable CLI options with -o key={object} #3310
new(falco): enable CLI options with -o key={object} #3310
Conversation
/milestone 0.39.0 |
Signed-off-by: Luca Guerra <luca@guerra.sh>
Signed-off-by: Luca Guerra <luca@guerra.sh>
1f753f1
to
46d77ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Neat, thanks!
LGTM label has been added. Git tree hash: a28816c9866ca21508908e207b9cc088b378f1fe
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
In #3308 we add a new configuration option such as:
Given its format, it is not possible to specify it on the command line with a
-o
option unless we enable a syntax like-o key={object}
, or-o key[]={object}
. Example:-o append_output[]={"source": "syscall", "tag": "persistence", "rule": "some rule name", "format": "gparent=%proc.aname[2] ggparent=%proc.aname[3] gggparent=%proc.aname[4]"}
. This PR does exactly that.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
For now, we are not enabling lists here but they can be allowed as well.
Does this PR introduce a user-facing change?: