Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(userspace/falco)!: drop deprecated -t,-T,-D options. #3311

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Sep 5, 2024

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area engine

What this PR does / why we need it:

#3193 deprecated 3 options for 0.38.0.
It's time to drop them for the 0.39.0 release.

Refs #3045.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

cleanup(userspace/falco)!: drop deprecated -t,-T,-D options.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP
Copy link
Contributor Author

FedeDP commented Sep 5, 2024

Refs #3045

/milestone 0.39.0

@FedeDP
Copy link
Contributor Author

FedeDP commented Sep 5, 2024

falcosecurity/testing#62 fixes testing framework.

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Sep 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit dabfe0e into master Sep 6, 2024
33 checks passed
@poiana poiana deleted the cleanup/drop_deprecated_options branch September 6, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants